Security context

Highlights

Authentication Bypass: 8 prior fixes. Scrutinize any change in this area.

world-chain-builder/src/pool/validator.rs: most-fixed (7 issues). Treat as high-risk during review.

34 high-severity fixes in this history; regressions here are high-impact.

Recurring patterns

Authentication Bypass: Multiple critical fixes show that semaphore proof verification was missing or disabled, allowing transactions without valid proofs. The pattern of adding verify_proof, signal hash validation, and nullifier hash validation indicates a systemic gap where the validator trusted unverified data.

Signature Verification Bypass: Multiple fixes in Solidity contracts show incorrect signature length calculations, wrong byte offsets, and missing World ID proof verification. These issues allowed forged or malformed signatures to pass validation, often due to dynamic data sizes not being accounted for.

Authentication Bypass: Nitro attestation verification was repeatedly patched to add COSE signature and certificate chain validation. The initial implementation only checked PCRs, allowing forged attestations. The fixes indicate a fundamental gap in verifying the authenticity of attestation documents.