Security context

What an agent needs to avoid regressing past fixes and find the next vuln in this repo.

rommapp/romm

              master @ 9a10fd0
            

Fixes

CVEs

CRITICAL

Peak severity

36.1%

Coverage

Highlights

Auth Bypass: 32 prior fixes. Scrutinize any change in this area.

backend/endpoints/identity.py: most-fixed (9 issues). Treat as high-risk during review.

72 high-severity fixes in this history; regressions here are high-impact.

Recurring patterns

The bug types that recur here, drawn from past fixes, not open vulnerabilities.

Auth Bypass: Token lifecycle is the most patched area: refresh token reuse, scope confusion between access/refresh tokens, JWT algorithm confusion, and missing user.enabled checks all allowed unauthorized access. These fixes are scattered across multiple handlers, suggesting systemic token-handling weaknesses.

Broken Access Control: Hidden-ROM/platform visibility checks (assert_rom_visible) were missing on many child routes, file endpoints, and asset downloads, enabling cross-user data access. Multiple fixes added these checks individually, indicating a pattern of incomplete enforcement across the ROM/asset API surface.

SSRF: SSRF defenses were repeatedly bypassed and had to be strengthened in layers: host allowlists, IP validation, DNS rebinding protection, and blocking non-standard IP representations. The fixes span multiple components (SSRF client, URL validator, external service handlers), indicating a broad attack surface for outbound HTTP requests.