Highlights
Denial of Service: 22 prior fixes. Scrutinize any change in this area.
x/interchainstaking/keeper/delegation.go: most-fixed (4 issues). Treat as high-risk during review.
22 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Denial of Service: Non-deterministic iteration over Go maps in delegation planning and validator allocation workflows can lead to state divergence and immediate consensus halts across the network. Safe sorted wrappers must always be used before iterating over dynamic maps in state-machine logic.
Denial of Service: Race conditions, unsafe counter manipulations, and integer underflow in tracking withdrawal waitgroups have caused state-machine crashes and deadlocks. Thread-safe execution and explicitly bounds-checked helpers are critical for state metrics.
Auth Bypass: Allowing arbitrary or stale interchain query submissions enables attackers to execute unauthorized callback paths or bypass verification checks. Strictly validating callback registration identifiers against a static allowlist is a mandatory security boundary.