Security context
What an agent needs to avoid regressing past fixes and find the next vuln in this repo.
midas-apps/contracts-solana
main @ 2932436
4
Fixes
0
CVEs
HIGH
Peak severity
50.0%
Coverage
Highlights
Access Control: 2 prior fixes. Scrutinize any change in this area.
programs/access-control/src/instructions/update_account_ac.rs: most-fixed (1 issue). Treat as high-risk during review.
3 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Access Control: The request_redeemer account was validated via a PDA seed check that could be bypassed with a forged seed; the fix replaced it with an explicit address constraint derived from state, indicating a high-risk pattern of trusting caller-supplied seeds for authority verification.
Auth Bypass: The mint_token sink lacked role-based access control, allowing unauthorized minting; the fix added a vault_minter_role PDA check, showing that mint operations must gate on a dedicated role PDA rather than implicit signer assumptions.
Privilege Escalation: The transfer-upgrade-authority script allowed setting an arbitrary new authority, enabling privilege escalation; the fix added validation that the new authority must be timelock or payer and checks the current authority, highlighting that upgrade authority transfers must be constrained to trusted parties.