Highlights
Command Injection: 7 prior fixes. Scrutinize any change in this area.
crates/chat-cli/src/cli/chat/tools/execute/mod.rs: most-fixed (7 issues). Treat as high-risk during review.
10 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Command Injection: Attackers can bypass regex and command validation checks to execute arbitrary commands by leveraging special characters, shell parameters, or dangerous flags in utility commands like find or grep.
Auth Bypass: A logic flaw where invalid or unsupported regex patterns in the command execution blocklist fail silently, defaulting to allowing the command rather than rejecting it.
Path Traversal: Untrusted agent names could escape intended directory boundaries when generating or resolving agent configuration paths via file-system joins.