Security context

Highlights

Buffer Overflow: 1 prior fix. Scrutinize any change in this area.

linenoise.c: most-fixed (2 issues). Treat as high-risk during review.

0 high-severity fixes in this history; regressions here are high-impact.

Recurring patterns

Local Privilege Escalation: A TOCTOU race between checking/operating on a file path and the actual operation allows a local attacker to swap the file with a symlink, altering permissions on arbitrary files. The fix switched to fchmod on the open descriptor, but any residual path-based operations on history/temp files remain at risk.

Buffer Overflow: An off-by-one error writes a null terminator at index buflen instead of buflen-1, causing a heap overflow when the buffer is full. This can corrupt adjacent heap metadata and lead to memory corruption. The fix corrected the index, but similar off-by-one patterns may exist in other string-copy or history-manipulation paths.