Highlights
Open Redirect: 12 prior fixes. Scrutinize any change in this area.
app/controllers/shopify_app/sessions_controller.rb: most-fixed (4 issues). Treat as high-risk during review.
16 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Auth Bypass: Session tokens were historically parsed without enforcing signature checks or specific cryptographic algorithms (such as HS256), allowing malicious actors to forge arbitrary JWT payloads and bypass authentication checks completely.
Open Redirect: Sanitizing redirect targets is complex due to parser differentials (e.g., handling backslashes and '@' symbols in URIs), which led to numerous open redirect bypasses when checking for trusted domains.
Auth Bypass: Downstream token exchanges could be triggered based on user-provided shop parameters without validating that they match the cryptographically verified shop domain of the current authenticated context.