Security context

What an agent needs to avoid regressing past fixes and find the next vuln in this repo.

ProtonMail/android-mail

              main @ 5a0210f
            

Fixes

CVEs

HIGH

Peak severity

60.0%

Coverage

Highlights

Auth Bypass: 8 prior fixes. Scrutinize any change in this area.

mail-detail: most-fixed (3 issues). Treat as high-risk during review.

7 high-severity fixes in this history; regressions here are high-impact.

Recurring patterns

The bug types that recur here, drawn from past fixes, not open vulnerabilities.

Cross-Site Scripting (XSS): Rendering decrypted, untrusted email HTML bodies directly within Android WebViews poses high risk. Vulnerabilities have recurred due to client-side CSS injection, unsafe HTML tags, and attribute injection. Strict, centralized native HTML sanitization is crucial to prevent script execution.

Auth Bypass: Multi-factor authentication (OTP) and session-lock bypasses can occur if lifecycle transitions (like app pause/resume) or state validations (like OTP submission errors or incorrect PIN attempts) are not strictly gated or cleared. Ensuring correct flow propagation and UI buffer cleansing on failure is vital.

Path Traversal: Untrusted email attachment filenames present a path traversal risk when written to storage or prepared for external sharing. Failing to sanitize traversal patterns allow files to be written or accessed outside intended temporary directories.