Highlights
Auth Bypass: 13 prior fixes. Scrutinize any change in this area.
src/ga_auth_handlers.cpp: most-fixed (19 issues). Treat as high-risk during review.
37 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Auth Bypass: Multiple fixes close authentication bypasses by enforcing full session for signing operations, validating re-login credentials, and preventing unauthorized key substitution. The pattern is that session state and user consent are often not enforced on all code paths.
Signature Verification Bypass: Critical vulnerabilities allowed bypassing signature verification for Taproot transactions, either by not verifying p2tr signatures or by computing signature hashes over only a single input. These fixes are essential for fund security.
Consensus Bypass: SPV and header verification had off-by-one errors and lacked cross-validation, allowing acceptance of transactions on the last block or from inconsistent chains. This undermines the entire trust model for Electrum sessions.